Move expressMiddleware to express4 deep import #6612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While expressMiddleware has no runtime dependencies, it does rely on the specific API of Express 4. One of the nice things about Express is that its development had slowed and it was a very stable target, but all good things must come to an end: Express 5 may be coming soon expressjs/express#4920 (I kid: the changes in Express 5, like support for proper error handling with async functions, look great.) So let's preemptively put this under `/express4` so that if the Express 5 middleware needs to be a bit different (if nothing else, the req/res types in the context function may vary) that we'll have an obvious place to put it. Fixes #6587.
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cf1a2d7:
|
trevor-scheer
approved these changes
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While expressMiddleware has no runtime dependencies, it does rely on the
specific API of Express 4. One of the nice things about Express is that
its development had slowed and it was a very stable target, but all good
things must come to an end: Express 5 may be coming soon
expressjs/express#4920
(I kid: the changes in Express 5, like support for proper error handling
with async functions, look great.)
So let's preemptively put this under
/express4so that if the Express5 middleware needs to be a bit different (if nothing else, the req/res
types in the context function may vary) that we'll have an obvious place
to put it.
Fixes #6587.